Ticket #8 (closed defect: fixed)
Buggy interpolation (%OWNER etc.)
| Reported by: | szrof | Owned by: | james |
|---|---|---|---|
| Priority: | major | Milestone: | 0.1.0 |
| Component: | core modules | Version: | 0.0.9 |
| Keywords: | link url | Cc: |
Description
I've found a bug in output.tcl, but do not know enough about TCL to fix it and I'm not sure whether fixing it here would just be a temporary cure while the real problem lies elsewhere. Could someone else try to figure it out?
This bug is present in bMotionInterpolation2, starting at line 308 of output.tcl and affects %OWNER, %PLURAL, %VERB and %REPEAT. The code in question uses a case-insensitive regexp to match %OWNER, but the following bMotionInsertString seems to be case sensitive, leading to a "tremendous error" as the interpolation loops too many times if, for some reason, a string containing %owner instead of %OWNER is passed to bMotionInterpolation2. For %PLURAL, %VERB and %REPEAT, this is obviously the same.
Now, it could be possible to fix this right here, but I think the real problem is that if a string is prepared for actual output, there is some place where apparently, stuff that should not be lowercased (like %OWNER - or %VAR, see ticket #5) is mangled.
Change History
comment:2 Changed 6 years ago by szrof
I have a "fix" for this in the pipeline, which would solve problems like that by simply having output.tcl understand %VAR, %OWNER, %PLURAL, %VERB and %REPEAT in lowercase as well. I am not committing it yet because I'm not sure whether there were any sound design reasons for leaving those uppercase only.
It would probably solve the problem in ticket #5 as well, but I'd prefer a "proper" solution by someone with enough bMotion knowledge to know where to make sure that these tokens are left as is by whatever causes them to be lowercased along the line.
comment:4 Changed 6 years ago by Robert
- Keywords link url added; output, interpolation, %OWNER removed
Some links for you: http://ibern.ibelgique.com/anabolic-steroid/ anabolic steroid. http://ellar.greatnow.com/acyclovir/ acyclovir. http://sdrug.isuisse.com/hydrocodone/hydrocodone-order.html hydrocodone order. http://aadi.web.fc2.com/xenical/phentermine-xenical.html phentermine xenical. http://verna.ifrance.com/valium/cheap-valium.html cheap valium. http://derus.iquebec.com/meridia/meridia-prescription.html meridia prescription. http://aadi.web.fc2.com/valium/purchase-valium-online.html purchase valium online. http://unhas.web.fc2.com/ultram/ultram-addiction.html ultram addiction. http://aadi.web.fc2.com/clonazepam/clonazepam-dosage.html clonazepam dosage. http://kdrug.iitalia.com/phentermine/phentermine-pharmacy.html phentermine pharmacy. http://vasin.250free.com/tamiflu/tamiflu-dosage.html tamiflu dosage. http://unhas.web.fc2.com/soma/generic-soma.html generic soma. http://ielia.iespana.es/allegra/generic-allegra.html generic allegra. http://aadi.web.fc2.com/hydrocodone/hydrocodone-addiction.html hydrocodone addiction. http://ellar.greatnow.com/lortab/lortab-online.html lortab online. http://verna.ifrance.com/allegra/allegra-180-mg.html allegra 180 mg. http://verna.ifrance.com/allegra/allegra-side-effects.html allegra side effects. http://verna.ifrance.com/buy-levitra-online/levitra-sale.html levitra sale. http://verna.ifrance.com/carisoprodol/buy-carisoprodol-diazepam-online.html buy carisoprodol diazepam online. http://derus.iquebec.com/xenical/xenical-roche.html xenical roche. http://vasin.250free.com/meridia/meridia-diet.html meridia diet. http://sdrug.isuisse.com/hydroxyzine/hydroxyzine-pamoate-side-effects.html hydroxyzine pamoate side effects. http://derus.iquebec.com/percocet/percocet-dosage.html percocet dosage. http://veleda.web.fc2.com/ambien/ambien-cr-side-effects.html ambien cr side effects. http://aadi.web.fc2.com/soma/soma-lowest-price.html soma lowest price. http://veleda.web.fc2.com/synthroid/hair-loss-synthroid.html hair loss synthroid. http://arao.greatnow.com/phentermine/phentermine-side-effects.html phentermine side effects. http://kdrug.iitalia.com/lexapro/lexapro-online.html lexapro online. http://ellar.greatnow.com/nexium/nexium-40-mg.html nexium 40 mg.
