bMotion_random_away fix -- Johno Crawford

[bmotion]

When randomly going away the bot comes back immediately, below mods in bMotion_random_away procedure should do the trick :)

proc bMotion_random_away {} {

global bMotionLastEvent bMotionChannels bMotionInfo

set timeNow [clock seconds]

# check if it's worth doing anything if {[bMotion_setting_get "bitlbee"]} {

#never go away in bitlbee return 0

}

#override if we should never go away if {[bMotion_setting_get "useAway"] != 1} {

return 0

}

# find the least idle channel set mostRecent 0 set line "comparing idle times: " foreach channel $bMotionChannels {

catch {

append line "$channel=$bMotionLastEvent($channel) " if {$bMotionLastEvent($channel) > $mostRecent} {

set mostRecent $bMotionLastEvent($channel)

}

}

}

set gapTime [expr { int($bMotionInfo(maxIdleGap) * 10) }] bMotion_putloglev 1 * "bMotion: most recent: $mostRecent .. timenow $timeNow .. gap $gapTime"

if {($timeNow - $mostRecent) < $gapTime} {

return 0

}

if {$bMotionInfo(away) == 1} {

#away, don't do anything (and don't do randomstuff) return 0

}

if {[rand 4] == 0} {

putlog "bMotion: All channels are idle, going away" bMotionSetRandomAway return 1

}

return 0

}

[bmotion]

Better formatted..

proc bMotion_random_away {} {
        global bMotionLastEvent bMotionChannels bMotionInfo

        set timeNow [clock seconds]

        # check if it's worth doing anything
        if {[bMotion_setting_get "bitlbee"]} {
                #never go away in bitlbee
                return 0
        }

        #override if we should never go away
        if {[bMotion_setting_get "useAway"] != 1} {
                return 0
        }

        # find the least idle channel
        set mostRecent 0
        set line "comparing idle times: "
        foreach channel $bMotionChannels {
                catch {
                        append line "$channel=$bMotionLastEvent($channel) "
                        if {$bMotionLastEvent($channel) > $mostRecent} {
                                set mostRecent $bMotionLastEvent($channel)
                        }
                }
        }

        set gapTime [expr { int($bMotionInfo(maxIdleGap) * 10) }]
        bMotion_putloglev 1 * "bMotion: most recent: $mostRecent .. timenow $timeNow .. gap $gapTime"

        if {($timeNow - $mostRecent) < $gapTime} {
                return 0
        }

        if {$bMotionInfo(away) == 1} {
                #away, don't do anything (and don't do randomstuff)
                return 0
        }

        if {[rand 4] == 0} {
                putlog "bMotion: All channels are idle, going away"
                bMotionSetRandomAway
                return 1
        }

        return 0
}

[james]

Applied, thanks :)